linux-mips
[Top] [All Lists]

Re: IDE driver broken in bigendian 2.4.17 kernel

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: IDE driver broken in bigendian 2.4.17 kernel
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 17 Jan 2002 14:04:49 +0100 (MET)
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
In-reply-to: <3C46B151.7A15C5F4@mips.com>
Organization: Technical University of Gdansk
Sender: owner-linux-mips@oss.sgi.com
On Thu, 17 Jan 2002, Carsten Langgaard wrote:

> Due to changes in the string port macros/functions (insl, outsl, insw,
> ...) the bigendian IDE driver doesn't work anymore.
> I think we need to have local versions of these functions in
> include/asm-mips/ide.h, therefore these functions should be macros
> (#define) and not static functions in include/asm-mips/io.h (in order to
> redefine them).

 I believe the inline functions should be left as they are and the IDE
driver should use own ones that call the formers and perform byteswapping
on results as needed.  You should avoid the name clash. 

 Also if that's a chipset-specific issue and not an IDE host adapter's
one, this should be resolved globally as other devices/drivers may be
affected. 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>