linux-mips
[Top] [All Lists]

Re: vmalloc bugs in 2.4.5???

To: Ralf Baechle <ralf@oss.sgi.com>
Subject: Re: vmalloc bugs in 2.4.5???
From: "Tommy S. Christensen" <tommy.christensen@eicon.com>
Date: Thu, 27 Dec 2001 17:01:23 +0100
Cc: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>, dony.he@huawei.com, linux-mips@oss.sgi.com
References: <20011226013221.A737@dea.linux-mips.net> <20011227.105518.74756316.nemoto@toshiba-tops.co.jp> <20011227011222.A16695@dea.linux-mips.net> <20011227.125122.71082554.nemoto@toshiba-tops.co.jp> <20011227022936.A19397@dea.linux-mips.net>
Sender: owner-linux-mips@oss.sgi.com
Ralf Baechle wrote:
> 
> On Thu, Dec 27, 2001 at 12:51:22PM +0900, Atsushi Nemoto wrote:
> 
> > >>>>> On Thu, 27 Dec 2001 01:12:22 -0200, Ralf Baechle <ralf@oss.sgi.com> 
> > >>>>> said:
> > ralf> Yes, you're right as for the cache.  But there is no reason for
> > ralf> the TLB flush, right?
> >
> > Yes, I agree.
> 
> Ok, I'll make a patch for Marcelo.  Being in Brazil right now is useful,
> I can beat him into accepting it ;-)
> 
>   Ralf

Great! But please make sure that the cache is flushed after the pages
are allocated instead of before.

With 2.4.9 that still had the cache-flushing in vmalloc_area_pages(), I
got cache aliasing problems in low memory situations (since alloc_page()
will re-schedule when no pages are available).

-Tommy

<Prev in Thread] Current Thread [Next in Thread>