| To: | Ralf Baechle <ralf@oss.sgi.com> |
|---|---|
| Subject: | Re: PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers |
| From: | Jim Paris <jim@jtan.com> |
| Date: | Fri, 7 Dec 2001 13:15:21 -0500 |
| Cc: | Daniel Jacobowitz <dan@debian.org>, Geert Uytterhoeven <geert@linux-m68k.org>, "Bradley D. LaRonde" <brad@ltc.com>, Linux/MIPS Development <linux-mips@oss.sgi.com> |
| In-reply-to: | <20011207160636.B23798@dea.linux-mips.net>; from ralf@oss.sgi.com on Fri, Dec 07, 2001 at 04:06:36PM -0200 |
| References: | <20011207121416.A9583@dev1.ltc.com> <Pine.GSO.4.21.0112071830000.29896-100000@mullein.sonytel.be> <20011207123833.A23784@nevyn.them.org> <20011207160636.B23798@dea.linux-mips.net> |
| Reply-to: | jim@jtan.com |
| Sender: | owner-linux-mips@oss.sgi.com |
| User-agent: | Mutt/1.2.5i |
> There is imho not very much sense in such a macro / function being written
> in a way that returns any value, that is something like
>
> foo = set_io_port_base(...)
>
> doesn't make obvious sense. So it's written in a way which will take care
> of any attempt to use the return type.
So Brad's way allows things that weren't allowed before. But does
it break anything that works with the do/while construct?
You can take care of attempts to use the return type by voiding it:
#define set_io_port_base(base) \
(void)(*(unsigned long *)&mips_io_port_base = (base))
-jim
|
| Previous by Date: | Re: PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers, Ralf Baechle |
|---|---|
| Next by Date: | Re: PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers, Justin Carlson |
| Previous by Thread: | Re: PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers, Ralf Baechle |
| Next by Thread: | Re: PATCH: io.h remove detrimental do {...} whiles, add sequence points, add const modifiers, Justin Carlson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |