| To: | Alan Cox <alan@lxorguk.ukuu.org.uk> |
|---|---|
| Subject: | Re: pcmcia |
| From: | Pete Popov <ppopov@mvista.com> |
| Date: | 30 Nov 2001 09:50:51 -0800 |
| Cc: | "Guillermo A. Loyola" <gmo@broadcom.com>, linux-mips <linux-mips@oss.sgi.com>, sforge <linux-mips-kernel@lists.sourceforge.net> |
| In-reply-to: | <E169rrU-0004GN-00@the-village.bc.nu> |
| References: | <E169rrU-0004GN-00@the-village.bc.nu> |
| Sender: | owner-linux-mips@oss.sgi.com |
On Fri, 2001-11-30 at 09:54, Alan Cox wrote: > > > We need the same here, how about doing this instead: > > > > > > #ifdef __i386__ > > > typedef u_short ioaddr_t; > > > #else > > > typedef u_int ioaddr_t; > > > #endif > > > > That probably makes more sense. I wasn't sure if it's only x86 that > > needs? ioaddr_t to be a 16 bit type. > > Is there any platform where making it int actually -breaks-. I can't see how it would break anything ... but I've said that before. It's not a variable which maps a hardware register, a protocol field, etc, so it should be safe to just make it an int. > At least for 2.5 it would seem a lot saner to just make it bigger and see Pete |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: pcmcia, Alan Cox |
|---|---|
| Next by Date: | Re: math emulator patch, Kjeld Borch Egevang |
| Previous by Thread: | Re: pcmcia, Alan Cox |
| Next by Thread: | math emulator patch, Mark Salter |
| Indexes: | [Date] [Thread] [Top] [All Lists] |