linux-mips
[Top] [All Lists]

Re: BUG : Memory leak in Linux 2.4.2 MIPS SMP kernel

To: Krishna Kondaka <krishna@sanera.net>
Subject: Re: BUG : Memory leak in Linux 2.4.2 MIPS SMP kernel
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Wed, 14 Nov 2001 10:47:53 +1100
Cc: linux-mips@oss.sgi.com
In-reply-to: <200111132336.PAA06294@exceed1.sanera.net>; from krishna@sanera.net on Tue, Nov 13, 2001 at 03:36:32PM -0800
References: <200111132336.PAA06294@exceed1.sanera.net>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Tue, Nov 13, 2001 at 03:36:32PM -0800, Krishna Kondaka wrote:

> extern inline void destroy_context(struct mm_struct *mm)
> {
> #ifdef CONFIG_SMP
>         kfree((void *)mm->context);
> #else
>         /* Nothing to do.  */
> #endif
> }
> 
> And when I tested this I do not see the memory leak any more.

Almost correct, as James already explained you have to check for a
non-null pointer first.  We got a more elegant implementation of
context switching which I'll add to CVS asap; it gets away without
any memory allocation.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>