linux-mips
[Top] [All Lists]

Re: arcboot patches

To: Guido Guenther <agx@sigxcpu.org>
Subject: Re: arcboot patches
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Tue, 6 Nov 2001 11:35:18 -0800
Cc: linux-mips@oss.sgi.com
In-reply-to: <20011104233218.A15847@bogon.ms20.nix>; from agx@sigxcpu.org on Sun, Nov 04, 2001 at 11:32:19PM +0100
References: <20011104233218.A15847@bogon.ms20.nix>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Sun, Nov 04, 2001 at 11:32:19PM +0100, Guido Guenther wrote:

>  typedef struct {
> +#ifdef __MIPSEL__
>       ULONG LowPart;
> +     *LONG HighPart;
> +#else /* !(__MIPSEL__) */
>       LONG HighPart;
> +     ULONG LowPart;
> +#endif
>  } LARGEINTEGER;

Why not simply defining LARGEINTEGER as long long?

> Index: arclib/spb.h
> ===================================================================
> RCS file: /cvs/arcboot/arclib/spb.h,v
> retrieving revision 1.2
> diff -u -u -r1.2 spb.h
> --- arclib/spb.h      2001/03/20 02:55:56     1.2
> +++ arclib/spb.h      2001/11/04 22:06:28
> @@ -90,7 +90,7 @@
>       ADAPTER Adapters[1];
>  } SPB;
>  
> -#define SystemParameterBlock ((SPB *) 0x1000)
> +#define SystemParameterBlock ((SPB *) 0xA0001000UL) 

That should be 0x80001000UL I think.

> -EXT2LIB = /usr/lib/libext2fs.a
> +#EXT2LIB = /usr/lib/libext2fs.a
> +EXT2LIB = ../../e2fslib/e2fsprogs-1.25/lib/libext2fs.a

That needs to be a non-pic library which nobody has installed on his
system so I suggest we just put a copy of libext2fs into the arcboot
sources.  That would alos make arcboot selfcontained and eleminate
build problems.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>