linux-mips
[Top] [All Lists]

PATCH: require dev_id for shared irq

To: ralf@oss.sgi.com
Subject: PATCH: require dev_id for shared irq
From: "Bradley D. LaRonde" <brad@ltc.com>
Date: Sun, 28 Oct 2001 15:47:46 -0500
Cc: linux-mips@oss.sgi.com
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.3.20i
2001-10-28  Bradley D. LaRonde <brad@ltc.com>

- Require a dev_id for shared interrupts.

--- arch/mips/kernel/irq.c      2001/10/12 01:41:17     1.36
+++ arch/mips/kernel/irq.c      2001/10/28 20:43:19
@@ -350,18 +350,12 @@
        int retval;
        struct irqaction * action;
 
-#if 1
        /*
-        * Sanity-check: shared interrupts should REALLY pass in
-        * a real dev-ID, otherwise we'll have trouble later trying
-        * to figure out which interrupt is which (messes up the
-        * interrupt freeing logic etc).
+        * Shared interrupts require a dev_id, otherwise we can't
+        * later figure out which interrupt to free.
         */
-       if (irqflags & SA_SHIRQ) {
-               if (!dev_id)
-                       printk("Bad boy: %s (at 0x%x) called us without a 
dev_id!\n", devname, (&irq)[-1]);
-       }
-#endif
+       if ((irqflags & SA_SHIRQ) && !dev_id)
+               return -EINVAL;
 
        if (irq >= NR_IRQS)
                return -EINVAL;

<Prev in Thread] Current Thread [Next in Thread>
  • PATCH: require dev_id for shared irq, Bradley D. LaRonde <=