| To: | Machida Hiroyuki <machida@sm.sony.co.jp> |
|---|---|
| Subject: | Re: csum_ipv6_magic() |
| From: | Ralf Baechle <ralf@oss.sgi.com> |
| Date: | Mon, 22 Oct 2001 22:48:28 +0200 |
| Cc: | alan@lxorguk.ukuu.org.uk, linux-mips@oss.sgi.com |
| In-reply-to: | <20011022203324G.machida@sm.sony.co.jp>; from machida@sm.sony.co.jp on Mon, Oct 22, 2001 at 08:33:24PM +0900 |
| References: | <20011022151606V.machida@sm.sony.co.jp> <E15vZvr-000138-00@the-village.bc.nu> <20011022195619A.machida@sm.sony.co.jp> <20011022203324G.machida@sm.sony.co.jp> |
| Sender: | owner-linux-mips@oss.sgi.com |
| User-agent: | Mutt/1.2.5i |
On Mon, Oct 22, 2001 at 08:33:24PM +0900, Machida Hiroyuki wrote: > I found bugs in checksum.h. A sample fix is attached below. > > I perfer to use generic csum_ipv6_magic() in net/checksum.h > than this fix. Please someone show me improvements for this asm > version of csum_ipv6_magic(). The C version should produce code that performs identically on MIPS. As such we have no good reason to keep the assembler version. > * (csum_ipv6_magic): Have same paramter types as net/checksum.h. > Correct carry computation. Add a final carry. The len argument of that prototype should be __u32 because of IPv6 jumbograms. Ralf |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: The Linux binutils 2.11.92.0.7 is released., Klaus Naumann |
|---|---|
| Next by Date: | Re: The Linux binutils 2.11.92.0.7 is released., H . J . Lu |
| Previous by Thread: | Re: csum_ipv6_magic(), Machida Hiroyuki |
| Next by Thread: | Re: csum_ipv6_magic(), Machida Hiroyuki |
| Indexes: | [Date] [Thread] [Top] [All Lists] |