linux-mips
[Top] [All Lists]

Re: Remove ifdefs from setup_arch()

To: Gerald Champagne <gerald.champagne@esstech.com>
Subject: Re: Remove ifdefs from setup_arch()
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Wed, 3 Oct 2001 21:29:24 +0200
Cc: "linux-mips@oss.sgi.com" <linux-mips@oss.sgi.com>
In-reply-to: <3BBB62DE.3040003@esstech.com>; from gerald.champagne@esstech.com on Wed, Oct 03, 2001 at 02:11:26PM -0500
References: <3BBB62DE.3040003@esstech.com>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Wed, Oct 03, 2001 at 02:11:26PM -0500, Gerald Champagne wrote:

> For each configuration, only one case is compiled in.  Wouldn't it
> be simpler to just give the board-specific setup function a common name
> and consider it part of the board-specific api like all the other
> board-specific functions.  Can this be changed to just this:
> 
> -----------------
> void __init setup_arch(char **cmdline_p)
> {
>       void foo_setup(void);
> 
>       ...
> 
>       foo_setup();  /* someone pick a name for this */
>       ...
> -----------------
> 
> I'm trying to document an api for supporting an arbitrary board, and little
> things like this make it more difficult to define something along the lines
> of a bsp interface.  Any suggestions?  Any objections?

We used to allow support for multiple boards in one kernel binary though
that usually doesn't work for MIPS due to the large number of very different
systems.  People have asked to resurrect this option, so I'd like to go
for an option that only removes all those awful #ifdefs.  Something based
on ELF sections looks like a way to do this.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>