linux-mips
[Top] [All Lists]

RFC: run-time defining serial ports

To: linux-mips@oss.sgi.com
Subject: RFC: run-time defining serial ports
From: Jun Sun <jsun@mvista.com>
Date: Thu, 12 Jul 2001 17:50:33 -0700
Sender: owner-linux-mips@oss.sgi.com
As more and more boards are added to Linux-mips tree, many places are getting
crowdier and uglier, including serial.h.  The same thing is true for PPC and
other architectures.

It turns out an easy solution is to let every board sets the serial port
definitions at run-time through calling early_serial_setup() routine.

An easy fix for now is to give a default table size when no serial definition
is given, which at least reserves some slots in the rs_table array.  See the
patch below.

A better solution is probably to provide a config option to define the serial
table size.

A by-product of this arrangement is that you can configure a kernel for
multiple machines.

What do you think?

Jun

diff -Nru include/asm-mips/serial.h.orig include/asm-mips/serial.h
--- include/asm-mips/serial.h.orig      Wed May 16 15:58:29 2001
+++ include/asm-mips/serial.h   Thu Jul 12 17:06:05 2001
@@ -271,3 +271,6 @@
        AU1000_SERIAL_PORT_DEFNS        \
        DDB5477_SERIAL_PORT_DEFNS
 
+#ifnef SERIAL_PORT_DFNS
+#define RS_TABLE_SIZE          4
+#endif

<Prev in Thread] Current Thread [Next in Thread>