linux-mips
[Top] [All Lists]

Re: ksymoops changes for mips

To: linux-mips@oss.sgi.com
Subject: Re: ksymoops changes for mips
From: Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de>
Date: Thu, 28 Jun 2001 16:32:51 +0200
In-reply-to: <16633.993608517@kao2.melbourne.sgi.com>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.3.18i
Keith Owens wrote:
[snip]
> >The best option is for a mips64 kernel to indicate that it is 64 bit
> >and its endianess.  Instead of printing
> >
> >  "epc     : %016lx\n"
> >
> >print
> >
> >  "epc     : %016lx (64 "
> >#ifdef __MIPSEL__
> >             "LSB"
> >#else
> >             "MSB"
> >#endif
> >             ")\n"
> 
> I have a new ksymoops release coming up.  Is it OK if I include code to
> look for (64 LSB) and (64 MSB) in the oops and decode accordingly.  I
> don't expect the kernel to produce this output immediately, I just want
> agreement on the format that will be produced.

The appended patch introduces the new format in mips64. Maybe this speeds
up agreement about it. :-)


Thiemo


diff -BurPX /bigdisk/dl/src/dontdiff linux-orig/arch/mips64/mm/andes.c 
linux/arch/mips64/mm/andes.c
--- linux-orig/arch/mips64/mm/andes.c   Sat May 26 00:25:39 2001
+++ linux/arch/mips64/mm/andes.c        Thu Jun 28 15:19:32 2001
@@ -332,7 +381,13 @@
        printk("Lo      : %016lx\n", regs->lo);
 
        /* Saved cp0 registers. */
-       printk("epc     : %016lx\nbadvaddr: %016lx\n",
+       printk("epc     : %016lx (64 "
+#ifdef __MIPSEL__
+              "LSB"
+#else
+              "MSB"
+#endif
+              ")\nbadvaddr: %016lx\n",
               regs->cp0_epc, regs->cp0_badvaddr);
        printk("Status  : %08x\nCause   : %08x\n",
               (unsigned int) regs->cp0_status, (unsigned int) regs->cp0_cause);
diff -BurPX /bigdisk/dl/src/dontdiff linux-orig/arch/mips64/mm/r4xx0.c 
linux/arch/mips64/mm/r4xx0.c
--- linux-orig/arch/mips64/mm/r4xx0.c   Thu Mar 29 17:11:46 2001
+++ linux/arch/mips64/mm/r4xx0.c        Thu Jun 28 14:51:20 2001
@@ -2125,7 +2118,13 @@
        printk("Lo      : %016lx\n", regs->lo);
 
        /* Saved cp0 registers. */
-       printk("epc     : %016lx\nbadvaddr: %016lx\n",
+       printk("epc     : %016lx (64 "
+#ifdef __MIPSEL__
+              "LSB"
+#else
+              "MSB"
+#endif
+              ")\nbadvaddr: %016lx\n",
               regs->cp0_epc, regs->cp0_badvaddr);
        printk("Status  : %08x\nCause   : %08x\n",
               (unsigned int) regs->cp0_status, (unsigned int) regs->cp0_cause);

<Prev in Thread] Current Thread [Next in Thread>