linux-mips
[Top] [All Lists]

Re: Bug in get_insn_opcode.

To: Carsten Langgaard <carstenl@mips.com>
Subject: Re: Bug in get_insn_opcode.
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Sat, 3 Mar 2001 08:21:15 +0100
Cc: linux-mips@oss.sgi.com
In-reply-to: <3A9FD0D0.887E372F@mips.com>; from carstenl@mips.com on Fri, Mar 02, 2001 at 05:56:48PM +0100
References: <3A9FD0D0.887E372F@mips.com>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Fri, Mar 02, 2001 at 05:56:48PM +0100, Carsten Langgaard wrote:
> Date:   Fri, 02 Mar 2001 17:56:48 +0100
> From: Carsten Langgaard <carstenl@mips.com>
> To: linux-mips@oss.sgi.com
> Subject: Bug in get_insn_opcode.
> 
> There is a bug in the function get_insn_opcode in traps.c
> 
> As 'epc' is an int pointer here, it should only be increased by 1 (4
> byte) and not by 4 (4*4 = 16 bytes).
> See the patch below.

> Index: arch/mips/kernel/traps.c
> ===================================================================
> RCS file: /home/repository/sw/linux-2.4.0/arch/mips/kernel/traps.c,v
> retrieving revision 1.10
> diff -u -r1.10 traps.c
> --- traps.c     2001/02/28 13:46:43     1.10
> +++ traps.c     2001/03/02 16:50:27

Patch will behave (un-)funny on a cvs diff generated patch like this which
lacks full pathnames in the --- and +++ lines.  Patches for this
behaviour are available on ftp.cyclic.com (so it still exists ...) or in
more recent cvs rpms.

Applied anyway, of course.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>