linux-mips
[Top] [All Lists]

Re: Serious bug in uaccess.h

To: Fabrice Bellard <bellard@email.enst.fr>, Ralf Baechle <ralf@uni-koblenz.de>
Subject: Re: Serious bug in uaccess.h
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Wed, 28 Feb 2001 13:47:27 +0100 (MET)
Cc: linux-mips@oss.sgi.com
In-reply-to: <20010227232227.B384@email.enst.fr>
Organization: Technical University of Gdansk
Sender: owner-linux-mips@oss.sgi.com
On Tue, 27 Feb 2001, Fabrice Bellard wrote:

> I mean the code in arch/mips/lib/memcpy.S. It is possible to modify
> __copy_user so that it has exactly the same calling convention of a C
> function. Then, no asm is necessary in uaccess.h. It costs us a
> supplementary jump.

 You mean the supplementary return value in a2?  Hmm, it is always set to
zero!  Also "addu $1, %2, %3" makes no sense.

 Ralf, the code is weird.  The header implies you are the author.  Could
you please elaborate what you meant in copy_*_user()? 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +


<Prev in Thread] Current Thread [Next in Thread>