linux-mips
[Top] [All Lists]

Re: Serious bug in uaccess.h

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: Serious bug in uaccess.h
From: Fabrice Bellard <bellard@email.enst.fr>
Date: Tue, 27 Feb 2001 23:22:27 +0100
Cc: linux-mips@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1010227185131.9765A-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Feb 27, 2001 at 06:54:22PM +0100
References: <Pine.GSO.4.02.10102271629230.22188-100000@donjuan.enst.fr> <Pine.GSO.3.96.1010227185131.9765A-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Tue, Feb 27, 2001 at 06:54:22PM +0100, Maciej W. Rozycki wrote:
> > BTW, the kernel would be smaller by moving all the asm around __copy_user
> > in __copy_user itself. I am currently doing that. The cost is an added
> > 'jr' to jump to __memcpy. Do you think it is worthwhile to do that ?
> 
>  What asm do you mean?

I mean the code in arch/mips/lib/memcpy.S. It is possible to modify
__copy_user so that it has exactly the same calling convention of a C
function. Then, no asm is necessary in uaccess.h. It costs us a
supplementary jump.

Fabrice.

<Prev in Thread] Current Thread [Next in Thread>