linux-mips
[Top] [All Lists]

Re: crash in __alloc_bootmem_core on SGI current cvs

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: crash in __alloc_bootmem_core on SGI current cvs
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Tue, 16 Jan 2001 17:22:35 -0200
Cc: Florian Lohoff <flo@rfc822.org>, linux-mips@oss.sgi.com, Kanoj Sarcar <kanoj@engr.sgi.com>
In-reply-to: <Pine.GSO.3.96.1010116173639.5546P-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Jan 16, 2001 at 05:39:40PM +0100
References: <20010116172812.B7327@paradigm.rfc822.org> <Pine.GSO.3.96.1010116173639.5546P-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Tue, Jan 16, 2001 at 05:39:40PM +0100, Maciej W. Rozycki wrote:

> > Wouldnt be this correct ? Realsize is size - holes.
> > 
> > Index: mm/page_alloc.c
> > ===================================================================
> > RCS file: /cvs/linux/mm/page_alloc.c,v
> > retrieving revision 1.49
> > diff -u -r1.49 page_alloc.c
> > --- mm/page_alloc.c 2001/01/11 04:02:45     1.49
> > +++ mm/page_alloc.c 2001/01/16 16:26:55
> > @@ -824,7 +824,7 @@
> >             if (zholes_size)
> >                     realsize -= zholes_size[j];
> >  
> > -           printk("zone(%lu): %lu pages.\n", j, size);
> > +           printk("zone(%lu): %lu pages.\n", j, realsize);
> >             zone->size = size;
> >             zone->name = zone_names[j];
> >             zone->lock = SPIN_LOCK_UNLOCKED;
> 
>  It look reasonable but is it what was really intended?  You should ask
> the author or linux-kernel, I suppose. 

Which probably is Kanoj who is subscribed to this list.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>