linux-mips
[Top] [All Lists]

Re: crash in __alloc_bootmem_core on SGI current cvs

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: crash in __alloc_bootmem_core on SGI current cvs
From: Florian Lohoff <flo@rfc822.org>
Date: Tue, 16 Jan 2001 17:28:12 +0100
Cc: Ralf Baechle <ralf@oss.sgi.com>, linux-mips@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1010116170209.5546K-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Tue, Jan 16, 2001 at 05:06:29PM +0100
Organization: rfc822 - pure communication
References: <20010116135737.A13302@bacchus.dhis.org> <Pine.GSO.3.96.1010116170209.5546K-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-mips@oss.sgi.com
User-agent: Mutt/1.2.5i
On Tue, Jan 16, 2001 at 05:06:29PM +0100, Maciej W. Rozycki wrote:
> On Tue, 16 Jan 2001, Ralf Baechle wrote:
> 
> > > Before:
> > >   On node 0 totalpages: 589824
> > >   zone(0): 589824 pages.
> > > 
> > > 
> > > After:
> > >   On node 0 totalpages: 65536
> > >   zone(0): 65536 pages.
> > 
> > I probably already got used too machines with gigs of memory to notice ;-)
> 
>  The number actually denotes the highest page, regardless of the number of
> pages, so you only need a single page placed far away from address zero to
> observe such large counts.

Wouldnt be this correct ? Realsize is size - holes.

Index: mm/page_alloc.c
===================================================================
RCS file: /cvs/linux/mm/page_alloc.c,v
retrieving revision 1.49
diff -u -r1.49 page_alloc.c
--- mm/page_alloc.c     2001/01/11 04:02:45     1.49
+++ mm/page_alloc.c     2001/01/16 16:26:55
@@ -824,7 +824,7 @@
                if (zholes_size)
                        realsize -= zholes_size[j];
 
-               printk("zone(%lu): %lu pages.\n", j, size);
+               printk("zone(%lu): %lu pages.\n", j, realsize);
                zone->size = size;
                zone->name = zone_names[j];
                zone->lock = SPIN_LOCK_UNLOCKED;

Flo
-- 
Florian Lohoff                  flo@rfc822.org             +49-5201-669912
     Why is it called "common sense" when nobody seems to have any?


<Prev in Thread] Current Thread [Next in Thread>