Hello Ralf,
Should the dma_cache_inv actually be a dma_cache_wback_inv?
Also, the sni directory contains a dma.c which is they same
as pci-dma.c and should be removed.
Dan Aizenstros
Software Engineer
V3 Semicondutor Corp.
Ralf Baechle wrote:
>
> On Wed, Nov 22, 2000 at 09:30:32AM -0500, Dan Aizenstros wrote:
>
> > Is there any reason for having multiple copies of
> > the pci-dma.c file in Linux/MIPS. The are all
> > doing basically the same thing. We could have
> > just one copy in the arch/mips/lib directory
> > and have the Makefile build it if CONFIG_PCI
> > is defined.
>
> Sounds like a plan, done. Tell me if it breaks something ...
>
> Some chipsets have a builtin scatter / gather facility, those may need
> special variants of pci-dma.c for better support.
>
> > Also they appear to have an error in that they
> > convert the pointer that is returned from the
> > __get_free_pages function call into a KSEG1
> > address even if the pointer is NULL.
>
> Fixed.
>
> Ralf
|