linux-mips
[Top] [All Lists]

Re: Multiple copies of pci-dma.c file.

To: Dan Aizenstros <dan@vcubed.com>
Subject: Re: Multiple copies of pci-dma.c file.
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Wed, 22 Nov 2000 16:56:53 +0100
Cc: linux-mips@oss.sgi.com
In-reply-to: <3A1BD888.7FB3C6A6@vcubed.com>; from dan@vcubed.com on Wed, Nov 22, 2000 at 09:30:32AM -0500
References: <3A1BD888.7FB3C6A6@vcubed.com>
Sender: owner-linux-mips@oss.sgi.com
On Wed, Nov 22, 2000 at 09:30:32AM -0500, Dan Aizenstros wrote:

> Is there any reason for having multiple copies of
> the pci-dma.c file in Linux/MIPS.  The are all
> doing basically the same thing.  We could have
> just one copy in the arch/mips/lib directory
> and have the Makefile build it if CONFIG_PCI
> is defined.

Sounds like a plan, done.  Tell me if it breaks something ...

Some chipsets have a builtin scatter / gather facility, those may need
special variants of pci-dma.c for better support.

> Also they appear to have an error in that they
> convert the pointer that is returned from the
> __get_free_pages function call into a KSEG1
> address even if the pointer is NULL.

Fixed.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>