linux-mips
[Top] [All Lists]

Re: Proposal: non-PC ISA bus support

To: frowand@mvista.com
Subject: Re: Proposal: non-PC ISA bus support
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 20 Jun 2000 19:29:14 +0200 (CEST)
Cc: Linux kernel <linux-kernel@vger.rutgers.edu>, Linux/PPC Development <linuxppc-dev@lists.linuxppc.org>, Linux/MIPS Development <linux@cthulhu.engr.sgi.com>
In-reply-to: <394FA5D1.DDAEA1F6@mvista.com>
Sender: owner-linux-mips@oss.sgi.com
On Tue, 20 Jun 2000, Frank Rowand wrote:
> Geert Uytterhoeven wrote:
> > The following patch fixes 2 problems related to ISA bus access on non-PC
> > platforms:

    [...]

> Would it make sense to apply the same sort of fix to the following code in
> __ioremap(), so that ISA space is handled consistently?:
> 
>         /*
>          * If the address lies within the first 16 MB, assume it's in ISA
>          * memory space
>          */
>         if (p < 16*1024*1024)
>             p += _ISA_MEM_BASE;

Yes. I added that correction because the NVRAM driver wants to ioremap() the 
NVRAM region as reported by the OF device tree, while on CHRP boxes with PC
style NVRAM, it's in ISA memory space at 0xe0000 (`nvram@me0000', according to
OF).

Gr{oetje,eeting}s,

                                                Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                                            -- Linus Torvalds


<Prev in Thread] Current Thread [Next in Thread>