linux-mips-fnet
[Top] [All Lists]

Re: scall_o32.S in 2.4.6 (or later)

To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Subject: Re: scall_o32.S in 2.4.6 (or later)
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Mon, 27 Aug 2001 08:30:17 +0200
Cc: linux-mips@fnet.fr, linux-mips@oss.sgi.com
In-reply-to: <20010827.101340.74756473.nemoto@toshiba-tops.co.jp>; from nemoto@toshiba-tops.co.jp on Mon, Aug 27, 2001 at 10:13:40AM +0900
References: <20010827.101340.74756473.nemoto@toshiba-tops.co.jp>
User-agent: Mutt/1.2.5i
On Mon, Aug 27, 2001 at 10:13:40AM +0900, Atsushi Nemoto wrote:

> After merging with 2.4.6, it seems that syscall destroy static
> registers.  Isnt't this needed?

Only if you insist on keeping register contents ;-)

The SAVE_STATIC was actually there, just at the wrong place, so the correct
patch is below.

Index: arch/mips/kernel/scall_o32.S
===================================================================
RCS file: /home/pub/cvs/linux/arch/mips/kernel/scall_o32.S,v
retrieving revision 1.16
diff -u -r1.16 scall_o32.S
--- arch/mips/kernel/scall_o32.S        2001/08/22 03:23:59     1.16
+++ arch/mips/kernel/scall_o32.S        2001/08/27 06:31:46
@@ -86,13 +86,13 @@
        ori     t0, t0, 1
        mtc0    t0, CP0_STATUS
 
+       SAVE_STATIC
        move    a0, zero
        move    a1, sp
        jal     do_signal
        b       restore_all
 
 o32_reschedule:
-       SAVE_STATIC
        jal     schedule
        b       o32_ret_from_sys_call
 

  Ralf

<Prev in Thread] Current Thread [Next in Thread>