linux-mips-fnet
[Top] [All Lists]

get_insn_opcode is broken (ll/sc emulation does not work)

To: linux-mips@fnet.fr, linux-mips@oss.sgi.com
Subject: get_insn_opcode is broken (ll/sc emulation does not work)
From: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Date: Fri, 24 Aug 2001 17:06:21 +0900 (JST)
Cc: Ralf Baechle <ralf@uni-koblenz.de>
Organization: TOSHIBA Personal Computer System Corporation
I found that get_insn_opcode(in traps.c) is broken.


static inline int get_insn_opcode(struct pt_regs *regs, unsigned int *opcode)
...
        if (!get_user(opcode, epc))


This must be:


static inline int get_insn_opcode(struct pt_regs *regs, unsigned int *opcode)
...
        if (!get_user(*opcode, epc))


Without this fix, ll/sc emulation might not work.

---
Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>