linux-mips-fnet
[Top] [All Lists]

Re: time_init() enables interrupt.

To: Atsushi Nemoto <nemoto@toshiba-tops.co.jp>
Subject: Re: time_init() enables interrupt.
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Mon, 23 Jul 2001 16:49:16 +0200
Cc: linux-mips@oss.sgi.com, linux-mips@fnet.fr
In-reply-to: <20010723190544N.nemoto@toshiba-tops.co.jp>; from nemoto@toshiba-tops.co.jp on Mon, Jul 23, 2001 at 07:05:44PM +0900
References: <20010723190544N.nemoto@toshiba-tops.co.jp>
User-agent: Mutt/1.2.5i
On Mon, Jul 23, 2001 at 07:05:44PM +0900, Atsushi Nemoto wrote:

> arch/mips/kernel/time.c:time_init() in current CVS contains following codes:
> 
>       /* setup xtime */
>       write_lock_irq(&xtime_lock);
>       xtime.tv_sec = rtc_get_time();
>       xtime.tv_usec = 0;
>       write_unlock_irq(&xtime_lock);
> 
> The write_unlock_irq() macro calls __sti(), but it is too early to
> enable interrupts.
> 
> I think this write_lock_irq/write_unlock_irq pair should be removed
> (or replaced with write_lock_irqsave/write_unlock_irqrestore pair).

There is no point in locking there.  This code is executed with interrupts
disabled on the boot cpu only.  I've removed the lock with no replacement.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>