linux-mips-fnet
[Top] [All Lists]

Re: linux 2.4.5: sysmips(MIPS_ATOMIC_SET) is broken (yep, again...)

To: Florian Lohoff <flo@rfc822.org>
Subject: Re: linux 2.4.5: sysmips(MIPS_ATOMIC_SET) is broken (yep, again...)
From: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Date: Thu, 5 Jul 2001 17:08:36 +0200 (MET DST)
Cc: Ralf Baechle <ralf@uni-koblenz.de>, linux-mips@fnet.fr, linux-mips@oss.sgi.com
In-reply-to: <20010705162705.B6963@paradigm.rfc822.org>
Organization: Technical University of Gdansk
On Thu, 5 Jul 2001, Florian Lohoff wrote:

> >  The R3k variant works fine for me.  I was unable to thest the ll/sc one,
> > but the semantics should be unchanged, i.e. if it worked before, so it
> > will now.  The patch should go into Linus' tree as well. 
> 
> How is this patch supposed to work in the means of how does it come around
> the -MAXERRNO stuff in scall32 ?

 It works as far as sysmips(MIPS_ATOMIC_SET) can.  It does not add
anything new -- it merely fixes what is obviously broken (falling through
to MIPS_FIXADE from MIPS_ATOMIC_SET for non-ll/sc CPUs, what is being
currently done, is not the most brilliant idea, either).  For better
handling I encourage you to use the _test_and_set patch I've sent here
recently.  I'm using it exclusively for a few weeks now. 

 I do not intend to maintain sysmips(MIPS_ATOMIC_SET) beyond fixing
obviously broken stuff.  I'm voting only to keep it until we have a
replacement.  It should go away in 2.5 for sure -- if you recall the
recent discussion, the conclusion was it's not really needed if we can
satisfy glibc differently. 

 I'd like to see Linus' 2.4.x working on R3k, OTOH.  It would be very
unfortunate if the official 2.4.x didn't work on R3k, just like 2.2.x (and
patches for 2.2.x were available at that time!). 

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

<Prev in Thread] Current Thread [Next in Thread>