linux-mips-fnet
[Top] [All Lists]

Re: modutils bug? 'if' clause executes incorrectly

To: Ralf Baechle <ralf@oss.sgi.com>
Subject: Re: modutils bug? 'if' clause executes incorrectly
From: Keith Owens <kaos@melbourne.sgi.com>
Date: Sat, 14 Oct 2000 02:43:59 +1100
Cc: Cort Dougan <cort@fsmlabs.com>, linux-mips@oss.sgi.com, linux-mips@fnet.fr
In-reply-to: Your message of "Fri, 13 Oct 2000 13:57:31 +0200." <20001013135731.A30919@bacchus.dhis.org>
On Fri, 13 Oct 2000 13:57:31 +0200, 
Ralf Baechle <ralf@oss.sgi.com> wrote:
>I think in your module the following jump gets misstreated:
>
>  90:   0800002d        j       b4 <init_module+ac>
>                        90: R_MIPS_26   .text
>
>But older modutils - including the modutils-2.1.121-12lm.src.rpm package
>from oss - do this:
>
>      *loc = (*loc & ~0x03ffffff) | ((*loc & 0x03ffffff) + (v >> 2));
>
>which is different - and wrong.

Would that be this entry in the change log from 1998?

Tue Nov  3 22:26:18 MET 1998  Ralf Baechle  <ralf@gnu.org>

        * obj/obj_mips.c (arch_apply_relocation): Fix application of R_MIPS_26
        relocations.

Thanks for tracking the problem down.  I really, *really* want to kill
people using modutils 2.1.121 on current kernels.

<Prev in Thread] Current Thread [Next in Thread>