| To: | Ralf Baechle <ralf@oss.sgi.com>, linux-mips@fnet.fr, linux-mips@oss.sgi.com |
|---|---|
| Subject: | Re: load_unaligned() and "uld" instruction |
| From: | Jun Sun <jsun@mvista.com> |
| Date: | Fri, 06 Oct 2000 18:35:15 -0700 |
| References: | <39CF9DFC.F30B302B@mvista.com> <200009252116.WAA01137@gladsmuir.algor.co.uk> <39CFC567.DD66BC56@mvista.com> <000d01c02782$32d31560$0deca8c0@Ulysses> <39D0E51C.79A0BE50@mvista.com> <20001005141354.E30075@bacchus.dhis.org> <39DD26CC.3805FFE8@mvista.com> <00d101c02f04$3a6d7340$0deca8c0@Ulysses> <39DD55E9.AFCACB0E@mvista.com> <011801c02f19$1283f6a0$0deca8c0@Ulysses> <39DD68DE.E9B26A3D@mvista.com> |
| Sender: | jsun@hermes.mvista.com |
Jun Sun wrote:
>
> Ralf, I notice you have fixed it in the CVS tree. Just did a test, and
> it looks good here.
>
I was too soon to say that ... :-)
While the __ldq_u() did work, I had a couple of syntax problems with
put_unaligned(). See the patch below.
In addition, my usb subsystem now hangs. It might mean a bug in the new
unaligned.h or the fix to unaligned.h reveals another bug. I will let
you know.
Jun
--- unaligned.h.ralf Fri Oct 6 18:32:34 2000
+++ unaligned.h Fri Oct 6 18:01:43 2000
@@ -117,20 +117,20 @@
__val;
\
})
-#define put_unaligned(x,ptr)
\
+#define put_unaligned(val,ptr)
\
do {
\
switch (sizeof(*(ptr))) {
\
case 1:
\
- *(unsigned char *)ptr = (val);
\
+ *(unsigned char *)(ptr) = (val);
\
break;
\
case 2:
\
- __stw_u(val, (unsigned short *)ptr);
\
+ __stw_u(val, (unsigned short *)(ptr));
\
break;
\
case 4:
\
- __stl_u(val, (unsigned int *)ptr);
\
+ __stl_u(val, (unsigned int *)(ptr));
\
break;
\
case 8:
\
- __stq_u(val, (unsigned long long *)ptr);
\
+ __stq_u(val, (unsigned long long *)(ptr));
\
break;
\
default:
\
__put_unaligned_bad_length();
\
|
| Previous by Date: | Re: load_unaligned() and "uld" instruction, Jun Sun |
|---|---|
| Next by Date: | Re: load_unaligned() and "uld" instruction, Kevin D. Kissell |
| Previous by Thread: | Re: load_unaligned() and "uld" instruction, Ralf Baechle |
| Next by Thread: | Re: load_unaligned() and "uld" instruction, Ralf Baechle |
| Indexes: | [Date] [Thread] [Top] [All Lists] |