linux-mips-fnet
[Top] [All Lists]

Re: CVS Update@oss.sgi.com: linux

To: Harald Koerfgen <Harald.Koerfgen@home.ivm.de>
Subject: Re: CVS Update@oss.sgi.com: linux
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Thu, 25 May 2000 01:58:43 +0200
Cc: Klaus Naumann <spock@mgnet.de>, Linux MIPS <linux-mips@fnet.fr>, SGI Linux <linux@cthulhu.engr.sgi.com>
In-reply-to: <XFMail.000524185009.Harald.Koerfgen@home.ivm.de>; from Harald.Koerfgen@home.ivm.de on Wed, May 24, 2000 at 06:50:09PM +0200
References: <20000524012413.A5507@spock> <XFMail.000524185009.Harald.Koerfgen@home.ivm.de>
On Wed, May 24, 2000 at 06:50:09PM +0200, Harald Koerfgen wrote:

> Ok, trying to fix that I added a fastdep rule to arch/mips/tools/Makefile 
> only to
> find myself in a catch 22 situation. offset.c includes asm/ptrace.h which, in
> turn, includes asm/offset.h, i.e. you have to have offset.h to create 
> offset.h :-o
> 
> Without heavily messing around with several header files, which may have an
> impact on non-MIPS platforms as well, I see no easy solution for that. Adding 
> an
> empty offset.h, on the other hand, and leaving the .cvsignore in place should 
> at
> least partially do what I want. Any objections?
> 
> And now for something completly different. Why the hell did I mess around with
> that?
> 
> Well, if something in the kernel is changed which affects offset.h then
> generating a diff against a fresh CVS copy will contain those differences. 
> That
> annoyed me because, personally, I find this disturbing when reviewing those 
> diffs.
> Nobody really needs that anyway, at least that's what I thought, because 
> offset.h
> is generated automatically.
> 
> The suggestion I made above would not solve that but at least avoids that 
> those
> changes creep into the CVS.

A good solution is important now that we have SMP.  Toggling CONFIG_SMP
affects offset.h and not for all variations of make invocations we
actually have the guarantee that offset.h is being rebuilt before using
it.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>