On 16-Apr-00 Mike Klar wrote:
> While tracking down a random memory corruption bug, I stumbled across the
> cause of that telnet/ssh problem in recent kernels reported about a month
> ago:
>
> The version of down_trylock() for CPUs with support LL/SC assumes that
> struct semaphore is 64-bit aligned, since it accesses count and waking as a
> single dualword (with lld/scd).
Good spotted. This is perfectly in line with my observation that telnet/ssh
worked perfectly well if you built a kernel without CONFIG_CPU_HAS_LLSC.
The attached patch seems to fix this, and another bug in
waking_non_zero_interruptible() as well.
Telnet is working again :)
--
Regards,
Harald
sema-fix-041700
Description: sema-fix-041700
|