linux-mips-fnet
[Top] [All Lists]

Re: dz driver

To: "Gleb O. Raiko" <raiko@niisi.msk.ru>
Subject: Re: dz driver
From: Ralf Baechle <ralf@uni-koblenz.de>
Date: Mon, 27 Sep 1999 17:39:23 +0200
Cc: linux-mips@fnet.fr
In-reply-to: <37E9FA14.A1439DA7@niisi.msk.ru>; from Gleb O. Raiko on Thu, Sep 23, 1999 at 01:59:48PM +0400
References: <19990922132742.A4440@uni-koblenz.de> <37E9FA14.A1439DA7@niisi.msk.ru>
On Thu, Sep 23, 1999 at 01:59:48PM +0400, Gleb O. Raiko wrote:

> > Could somebody of the DECstation people please check if the fix for
> > sgiserial.c which I checked into CVS last night also is required for it?
> 
> While I'm not a DECstation guy, I've checked the changes it order to
> ensure DECstation zs driver suffers from the problem. Why I'm care of
> any changes in the serial drivers is the fact I observe the situation
> where my Baget with the Zilog chip running 2.3.9 hangs somewhere in
> getty and other Baget with the VAC chip not. 2.2.1 works fine.
> 
> Well, the zs driver seems to handle this case. Perhaps, we might remove
> that unnecessary check in the zs driver too (hint!), but thinking the zs
> driver full of other unnecessary things it's not so urgent. 
> 
> Regarding the patch why to not call transmit_chars() instead of manually
> feed the chip. transmit_chars makes that in the right way (and wakes up
> others levels, if needed, btw).
> Also, do you really need setup new value in the junk local variable just
> before exit from rs_put_char :-).

The original Sun driver zs.c has received lots of fixes and cleanups.
Somebody may finally want to turn it into a generic driver in order to
keep the plentora of 8530 drivers from further growing ...

  Ralf

<Prev in Thread] Current Thread [Next in Thread>