linux-cvs
[Top] [All Lists]

CVS Update@linux-mips.org: linux

To: linux-cvs@linux-mips.org
Subject: CVS Update@linux-mips.org: linux
From: ralf@linux-mips.org
Date: Tue, 20 Sep 2005 11:56:27 +0100
Reply-to: linux-mips@linux-mips.org
Sender: linux-cvs-bounce@linux-mips.org
CVSROOT:        /home/cvs
Module name:    linux
Changes by:     ralf@ftp.linux-mips.org 05/09/20 11:56:27

Modified files:
        include/asm-mips: checksum.h 

Log message:
        The type of sum in csum_tcpudp_nofold is "unsigned int", so when we 
assign
        to it in an asm() block, and we're running on a system with 64-bit
        registers, it is vitally important that we sign extend it correctly 
before
        returning to C.  Otherwise the stray high bits will be preserved into
        csum_fold, and on the SB-1 processor, 32-bit arithmetic on a non
        sign-extended register will yield surprising results.
        
        This caused incorrect checksums in some UDP packets for NFS root.  The
        problem was mild when using a 10.0.1.x IP address, but severe when
        using 192.168.1.x.
        
        Signed-off-by: Daniel Jacobowitz <dan@codesourcery.com>


<Prev in Thread] Current Thread [Next in Thread>