linux-cvs
[Top] [All Lists]

Re: CVS Update@oss.sgi.com: linux

To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: CVS Update@oss.sgi.com: linux
From: Ralf Baechle <ralf@oss.sgi.com>
Date: Mon, 15 Jan 2001 17:07:48 -0200
Cc: Harald Koerfgen <harald@oss.sgi.com>, linux-cvs@oss.sgi.com
In-reply-to: <Pine.GSO.3.96.1010115174821.16619P-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Mon, Jan 15, 2001 at 06:03:10PM +0100
References: <20010112204419Z553818-486+591@oss.sgi.com> <Pine.GSO.3.96.1010115174821.16619P-100000@delta.ds2.pg.gda.pl>
Sender: owner-linux-cvs@oss.sgi.com
User-agent: Mutt/1.2.5i
On Mon, Jan 15, 2001 at 06:03:10PM +0100, Maciej W. Rozycki wrote:

> > Modified files:
> >     arch/mips/dec  : Makefile rtc-dec.c 
> 
>  Hmm, shouldn't it use <linux/spinlock.h> instead?  Anyway it's
> include/linux/mc146818rtc.h that should be fixed instead -- there's
> nothing in rtc-dec.c that would need spinlocks. 

Sure, but that's !#@$#@^ typical Linux.  The include file structure sucks.
Frequently the only reason why things get written as macros is to avoid
having to include one header into another which makes the code more
confusing.  In the end the actual kernel code includes a giant load
of include files and nobody knows why they're necessary.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>