linux-cvs-patches
[Top] [All Lists]

CVS Update@linux-mips.org: linux

To: linux-cvs-patches@linux-mips.org
Subject: CVS Update@linux-mips.org: linux
From: ralf@linux-mips.org
Date: Tue, 20 Sep 2005 11:58:56 +0100
Reply-to: linux-mips@linux-mips.org
Sender: linux-cvs-patches-bounce@linux-mips.org
CVSROOT:        /home/cvs
Module name:    linux
Changes by:     ralf@ftp.linux-mips.org 05/09/20 11:58:50

Modified files:
        include/asm-mips64: Tag: linux_2_4 checksum.h 

Log message:
        The type of sum in csum_tcpudp_nofold is "unsigned int", so when we
        assign to it in an asm() block, and we're running on a system with
        64-bit registers, it is vitally important that we sign extend it
        correctly before returning to C.  Otherwise the stray high bits will be
        preserved into csum_fold, and on the SB-1 processor, 32-bit arithmetic
        on a non sign-extended register will yield surprising results.
        
        This caused incorrect checksums in some UDP packets for NFS root.  The
        problem was mild when using a 10.0.1.x IP address, but severe when
        using 192.168.1.x.
        
        Signed-off-by: Daniel Jacobowitz <dan@codesourcery.com>

diff -urN linux/include/asm-mips64/checksum.h 
linux/include/asm-mips64/checksum.h
--- linux/include/asm-mips64/Attic/checksum.h   2004/04/23 21:00:53     1.12.2.5
+++ linux/include/asm-mips64/Attic/checksum.h   2005/09/20 10:58:50     1.12.2.6
@@ -144,7 +144,7 @@
        "daddu\t%0, %4\n\t"
        "dsll32\t$1, %0, 0\n\t"
        "daddu\t%0, $1\n\t"
-       "dsrl32\t%0, %0, 0\n\t"
+       "dsra32\t%0, %0, 0\n\t"
        ".set\tat"
        : "=&r" (sum)
        : "0" (daddr), "r"(saddr),

<Prev in Thread] Current Thread [Next in Thread>