freecwmp
[Top] [All Lists]

Re: Patch for two memleaks in connection request scenario

To: Rajsek Miroslav <miroslav.rajsek@innbox.net>
Subject: Re: Patch for two memleaks in connection request scenario
From: Luka Perkov <freecwmp@lukaperkov.net>
Date: Mon, 19 Nov 2012 01:39:30 +0100
Cc: "freecwmp@linux-mips.org" <freecwmp@linux-mips.org>
In-reply-to: <96728A6499D0F74397BCA42A8B9F7215373E11414A@NTMAILKR.iskratel.si>
Mail-followup-to: Rajsek Miroslav <miroslav.rajsek@innbox.net>, "freecwmp@linux-mips.org" <freecwmp@linux-mips.org>
Original-recipient: rfc822;freecwmp@linux-mips.org
References: <96728A6499D0F74397BCA42A8B9F7215373E11414A@NTMAILKR.iskratel.si>
Sender: freecwmp-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
Hi Miroslav,

On Fri, Nov 16, 2012 at 01:56:10PM +0100, Rajsek Miroslav wrote:
> My name is Miroslav Rajsek, I am from Slovenia, working for a CPE 
> manufacturer.
> I am responsible for TR-069, so I am following freecwmp project more or less 
> intensively for about two or three months. I am subscribed at #freecwmp IRC, 
> my nickname is rajsek.
> I am using Motive HDM and NetMania AcsLite TR-069 ACSs in my test 
> environment, OpenACS from time to time. 

Good to know. Welcome aboard :)
 
> I am testing freecwmp-curl in development environment on my ubuntu desktop. I 
> have also ported freecwmp-curl to one of our CPE under development, based on 
> PowerPC and using openwrt. 
> Today I was running freecwmp with valgrind on my ubuntu and noticed two small 
> memory leaks in scenario when connection request was sent from ACS.  As far 
> as fetching latest commits it seems to me a fix has not been provided yet. 
> However it could be the thing is already known to you.
> 
> So I have a patch proposal below. Note that this is my very first patch. 
> Please can you check it, I am glad if you find it useful. 

Thank you. I have applied this.

Please next time when sending a patch add a "Signed-off-by" line.

Regards,
Luka

<Prev in Thread] Current Thread [Next in Thread>