freecwmp
[Top] [All Lists]

Re: NEW PATCH for data model

To: KALLEL Mohamed <mohamed.kallel@pivasoftware.com>
Subject: Re: NEW PATCH for data model
From: Jonas Gorski <jonas.gorski@gmail.com>
Date: Fri, 16 Nov 2012 19:19:47 +0100
Cc: freecwmp@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=d49t46y8TjdeZ+DIS9eCqY45h7jHXgVD5HKWy7Dxy3Y=; b=m7RvHtv5cbTpQHafqs4Zm5ATkDJYx7oZMfX64w7l9hNenQBNZmaJSv6vzEomCVi7km 62UJsIhjDtZ4NuwINlFgAvc5L7Msz7tsTtjPEn8TY2UWbry3r1GjZyjaxs+gcGOle2on XyCD0KzhC0e5DkU0yiuYHjm0Us8I2IXlR7hijkOweSoXsxe8W8ripnOdoDYETEuA0dW8 jzkqVppCa0p3zd+AqqN8voEGu/Oxant0u33Xkrw/D78QDSK38oi2HYbxxPr2v9TnnJHL Bpc9HWk9A1V6dkD+911aGA4an8cEpD+4dANPmwNx0vfZ30wd7k55EZP+BGmdJA1XyOKz 4qrw==
In-reply-to: <50A676F4.8080708@pivasoftware.com>
Original-recipient: rfc822;freecwmp@linux-mips.org
References: <508E5D2B.6050508@pivasoftware.com> <50A676F4.8080708@pivasoftware.com>
Sender: freecwmp-bounce@linux-mips.org
Hi Mohamed,

On 16 November 2012 18:25, KALLEL Mohamed
<mohamed.kallel@pivasoftware.com> wrote:
> Hi Luka
> please find attached a new patch.
>  This patch contains:
> - Support for GetParameterName method.
> - The communication from external script to core is replaced by ubus.
> - Update GetParameterValue method in order to support many parameter names
> and in order to support parameter type.
> - Update GetParameterNames related scripts

These are four different things, your patch should only contain one.
Please split this into smaller, easier to review patches. You are also
missing your Signed-off-by.

Regards
Jonas

<Prev in Thread] Current Thread [Next in Thread>