freecwmp
[Top] [All Lists]

Re: [PATCH] fix freecwmp Openwrt Makefile dependencies

To: freecwmp@linux-mips.org
Subject: Re: [PATCH] fix freecwmp Openwrt Makefile dependencies
From: Luka Perkov <freecwmp@lukaperkov.net>
Date: Sat, 18 Feb 2012 22:16:45 +0100
Authentication-results: mr.google.com; spf=pass (google.com: domain of freecwmp@lukaperkov.net designates 10.213.10.4 as permitted sender) smtp.mail=freecwmp@lukaperkov.net
In-reply-to: <4F3E1F0C.7090002@schleiser.de>
Mail-followup-to: freecwmp@linux-mips.org
Original-recipient: rfc822;freecwmp@linux-mips.org
References: <4F3CFA48.2040701@schleiser.de> <4F3D0107.8020803@schleiser.de> <20120216210904.GA26359@w500.iskon.local> <4F3E1F0C.7090002@schleiser.de>
Sender: freecwmp-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
Hi Kaspar,

On Fri, Feb 17, 2012 at 10:34:04AM +0100, Kaspar Schleiser wrote:
> well, this way the dependencies don't get set, so a cean rebuild will
> not ensure a build order that makes the library headers accessible
> during freecwmp build.
> 
> I think that adding
> 
> "+CONFIG_FREECWMP_HTTP_ZSTREAM:libzstream
> +CONFIG_FREECWMP_HTTP_CURL:libcurl"
> 
> to DEPENDS fixes that.

Yes. Now we have in Config.in:

choice
        prompt "Select HTTP library"
        default FREECWMP_HTTP_ZSTREAM

        config FREECWMP_HTTP_ZSTREAM
        default y if !PACKAGE_libcurl
        select PACKAGE_libzstream
        bool "libzstream"

        config FREECWMP_HTTP_CURL
        default y if PACKAGE_libcurl
        select PACKAGE_libcurl
        bool "libcurl"
endchoice

And in Makefile:

  DEPENDS:=+libubox +libmicroxml +shflags 
+CONFIG_FREECWMP_HTTP_ZSTREAM:libzstream +CONFIG_FREECWMP_HTTP_CURL:libcurl

Luka

<Prev in Thread] Current Thread [Next in Thread>